search

gyroflow / gyroflow-ofx

GNU General Public License v3.0
114 stars 7 forks source link

Caching of processed video clips #27

Closed muepla closed 1 year ago

muepla commented 1 year ago

@AdrianEddy About a week or so you added a cache to the DaVinci Gyroflow plugin for processed video clips.

static ref MANAGER_CACHE: Mutex<LruCache<String, Arc<StabilizationManager>>>

The cache does work but if you add the same clip twice to the timeline or if you cut a clip, it creates some unwanted side effects:

As intended, the second clip inherits all stabilization parameters of the first clip but the UI is grayed out. After a restart of DaVinci, the UI is enabled but the sliders do not work/reflect the actual stabilization parameters.

The workaround is probably a 'copy-on-write' caching algorithm.

AdrianEddy commented 1 year ago

Thanks, that's a good catch.

It has now been corrected: https://github.com/gyroflow/gyroflow-ofx/actions/runs/4286035444 BTW, new nightly app is available too https://gyroflow.xyz/devbuild/?autodownload