gyroflow / gyroflow-ofx

GNU General Public License v3.0
105 stars 7 forks source link

Quaternion changes #5

Closed ElvinC closed 2 years ago

ElvinC commented 2 years ago

Hi! Although I haven't tried your plugin yet (been learning some C++ and working on a plugin as well), just wanted to let you know that the output stabilization transform quaternions have been modified slightly to make better mathematical sense. See the dev branch here: https://github.com/ElvinC/gyroflow/blob/dev/calibrate_video.py#L351

Cheers

ilya-epifanov commented 2 years ago

@ElvinC somehow I missed this ticket. Thanks for the heads-up, I've actually fixed it a couple of days ago.

ElvinC commented 2 years ago

Awesome. I saw that you added some built packages. I'll make sure to have a try when I get a chance. Great work!

ilya-epifanov commented 2 years ago

Yeah, I had to completely remove OpenCV by rewriting the algorithms in rust just because packaging third-party libraries is such a PITA. Also, OpenCV didn't work 100% when loaded in Resolve's address space, so it didn't even try to use OpenCL. Good thing is that I parallelized the algorithms and they're now much faster than what OpenCV provides.