gyscos / cursive

A Text User Interface library for the Rust programming language
MIT License
4.26k stars 243 forks source link

Scroll the whole page on Left/Right arrows #764

Closed azat closed 4 months ago

azat commented 11 months ago

Seeking char by char can take awhile... Or maybe it is done on purpose?

michalfita commented 11 months ago

@azat this looks like semantic change to the existing behaviour; it's a candidate for different shortcut.

TBH: I'm surprised Ctrl+Arrow does just scrolling by the same amount than normal Arrow, I'd expect Ctrl and Shift to modify amount of the movement.

azat commented 11 months ago

this looks like semantic change to the existing behaviour; it's a candidate for different shortcut.

Scrolling just one column sounds odd anyway, for instance less does not do this (but it seeks half of screen by default, not the whole screen, while it does scroll the whole screen for vertical scroll).

TBH: I'm surprised Ctrl+Arrow does just scrolling by the same amount than normal Arrow, I'd expect Ctrl and Shift to modify amount of the movement.

So as I, I was thinking about using Ctrl+Left/Right instead, but decided that the default looks odd anyway and it could be adjusted, but I'm OK with using different binding for this as well.

azat commented 6 months ago

Kind ping on this one

gyscos commented 4 months ago

Hi, and thanks for the work!

Scrolling by 1 column was not a really deep decision, just what I left as default implementation (and, like anything temporary, it sticks forever). Fine to make it scroll a full screen.