gyscos / cursive

A Text User Interface library for the Rust programming language
MIT License
4.26k stars 243 forks source link

fixed links for examples in cursive/Readme.md #771

Closed Jadens-arc closed 4 months ago

Jadens-arc commented 8 months ago

Links for example programs were not linking to example code correctly. Now fixed

gyscos commented 4 months ago

Hi, and thanks for the report!

I see the problem - the readme is in the repository's root, and is symlinked inside cursive/. Conversely, the examples directory is inside the cursive/ folder, and symlinked into the repository's root.

As a result:

It doesn't sound easy to do both in the same file.

Instead, we might be able to move cursive/examples to the repo's root, and symlink it into cursive/. I'll try that.

EDIT: Aaand while it works on github, it won't work when rendered on crates.io, since it'll link to cursive/examples/... on github, which is a symlink (and github does not follow symlinks). Sooo I'm not sure relative URLs are an option.

gyscos commented 4 months ago

I ended up using absolute links, as it might be the only way to work on both github's front page and the crates-based pages.