search

gyscos / zstd-rs

A rust binding for the zstd compression library.
MIT License
527 stars 112 forks source link

Update zstd to v1.5.5 #220

Closed NobodyXu closed 1 year ago

NobodyXu commented 1 year ago

Fixed #213

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

dralley commented 1 year ago

@gyscos Can you perform a release?

gyscos commented 1 year ago

Zstd-sys-2.0.8 should have been released already with zstd 1.5.5?

dralley commented 1 year ago

But zstd-safe has zstd-sys 2.0.7 pinned: https://github.com/gyscos/zstd-rs/blob/main/zstd-safe/Cargo.toml#L19

So most people still get 1.5.4, even after cargo updateing all their dependencies.

NobodyXu commented 1 year ago

But zstd-safe has zstd-sys 2.0.7 pinned: https://github.com/gyscos/zstd-rs/blob/main/zstd-safe/Cargo.toml#L19

It does not pin zstd-sys to 2.0.7, it requires zstd-sys to be at least 2.0.7

So most people still get 1.5.4

They just need to run cargo update for that

dralley commented 1 year ago

Apologies, the actual problem is that the suffix of zstd-safe doesn't match up with the version of zstd-sys

   Compiling zstd-safe v6.0.5+zstd.1.5.4
...
...
   Compiling zstd-sys v2.0.8+zstd.1.5.5

That led to confusion. You are correct that the actual version of zstd being used is 1.5.5

NobodyXu commented 1 year ago

Yes, I also find that confusing.