gyselroth / balloon

High performance, feature rich document management system written for the cloud
GNU General Public License v3.0
18 stars 7 forks source link

Do not send notification based on temporary file changes #378

Closed raffis closed 4 years ago

raffis commented 4 years ago

Describe the change

balloon shold not send notifications for temporary files.

Current situation

Currently balloon sends notifications for files like ~$Meinfile.docx

Should

Ignore notifications for temporary files: https://github.com/gyselroth/balloon/blob/master/src/lib/Filesystem/Node/File.php#L44

(Also add ^\~\$ file to that list)

mathias-noethiger commented 4 years ago

is not yet working

image

Tested with Windows 10 VDI Word 2019 - balloonstage and balloon desktop 1.2.1

raffis commented 4 years ago

Lets match any files starting with ~ as temporary.

mathias-noethiger commented 4 years ago

it worked with regularly created temp files on my Mac. No notification was sent for the temp file just for the real file. image

image

rootinier commented 4 years ago

Close the tested issue.