gyselroth / balloon

High performance, feature rich document management system written for the cloud
GNU General Public License v3.0
18 stars 7 forks source link

wopi test Fail: files.PutFileReturnsDifferentVersion fails #423

Closed raffis closed 4 years ago

raffis commented 4 years ago

Describe the bug

The test fails because balloon internally does not increase the version of a node if the content hash equals the previous state.

  Fail: files.PutFileReturnsDifferentVersion
    Lock, response code: 200 OK
    CheckFileInfo, response code: 200 OK
    PutFile, response code: 200 OK
      'X-WOPI-ItemVersion' header value should not be : '117'
    Unlock, response code: 200 OK

Starting with balloon v2.7.x we should increase the version but still left out the other stuff like postUpdate handlers. There are likely other 3rd party tools which expect the version to be increased after a committed change even tough it is the same content as before.

To Reproduce

Execute make wopi-test

Expected behavior

Passes test.

Environment