search

gysiang / minishell

0 stars 1 forks source link

Echo "$PWD" memory overflow #131

Closed axellee1994 closed 4 months ago

axellee1994 commented 5 months ago

image

@gysiang

gysiang commented 5 months ago

@axellee1994 I can't replicate this issue.

minishell$ echo "$PWD" token: echo token type: 0 token: $PWD token type: 0 current token in process: echo /home/gyong-si/Documents/42/minishell minishell$ echo '$PWD' token: echo token type: 0 token: $PWD token type: 0 current token in process: echo /home/gyong-si/Documents/42/minishell minishell$

axellee1994 commented 5 months ago

@gysiang

Will need to check at school to see what the correct output is then. Now I am running on the actual physical linux on the VM and I am still getting the issue.

gysiang commented 5 months ago

@axellee1994 can you start refactoring and norm the code you have done? I'll try to work on fixing some of the echo issue.

axellee1994 commented 5 months ago

@axellee1994 can you start refactoring and norm the code you have done? I'll try to work on fixing some of the echo issue.

Can. Will get it back to you by 1pm latest.

axellee1994 commented 4 months ago

@gysiang Can you try and test to solve the echo "$PWD" issue on your side? I tried two ways of solving it but still no luck. Both of them stuck in an infinite loop when executing it.

Tried one method with array the other one is with refactoring the same code down to 4 arguments but still no luck.

Screenshot from 2024-06-09 17-47-49