Closed mamrai1 closed 3 years ago
Looks good! Fixes the typo. Disregard my push to my branch with the same thing.
Thank you
Maybe 7 sec would be enough?
On Fri, 18 Sep 2020, 08:45 melyux, notifications@github.com wrote:
@melyux commented on this pull request.
In src/mitsubishi2mqtt/mitsubishi2mqtt.ino https://github.com/gysmo38/mitsubishi2MQTT/pull/101#discussion_r490715124 :
@@ -1408,7 +1408,16 @@ void mqttCallback(char topic, byte payload, unsigned int length) { hp.update(); } else if (strcmp(topic, ha_temp_set_topic.c_str()) == 0) {
- //add to fix HP turn off after change temperature
- heatpumpSettings currentSettings = hp.getSettings();
- delay(10);
Was there a reason for this naked 10 second delay? Seems kind of drastic!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gysmo38/mitsubishi2MQTT/pull/101#pullrequestreview-491165928, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVCNGH7RHLNJFHQE7MVL4DSGLXW7ANCNFSM4QWALPFA .
But what is the purpose of the delay?
That delay doesn't seem to fix the turning off issue. Mine turns off anyway by itself sometimes.
1.fixed widevane error in compilation