search

gysmo38 / mitsubishi2MQTT

Mitsubishi to MQTT with ESP8266 module
GNU Lesser General Public License v2.1
390 stars 139 forks source link

Update mitsubishi2mqtt.ino (fixed widevane error in compilation) #101

Closed mamrai1 closed 3 years ago

mamrai1 commented 3 years ago

1.fixed widevane error in compilation

  1. removed dublicate entry of widevane mode 6
melyux commented 3 years ago

Looks good! Fixes the typo. Disregard my push to my branch with the same thing.

gysmo38 commented 3 years ago

Thank you

mamrai1 commented 3 years ago

Maybe 7 sec would be enough?

On Fri, 18 Sep 2020, 08:45 melyux, notifications@github.com wrote:

@melyux commented on this pull request.

In src/mitsubishi2mqtt/mitsubishi2mqtt.ino https://github.com/gysmo38/mitsubishi2MQTT/pull/101#discussion_r490715124 :

@@ -1408,7 +1408,16 @@ void mqttCallback(char topic, byte payload, unsigned int length) { hp.update(); } else if (strcmp(topic, ha_temp_set_topic.c_str()) == 0) {

  • //add to fix HP turn off after change temperature
  • heatpumpSettings currentSettings = hp.getSettings();
  • delay(10);

Was there a reason for this naked 10 second delay? Seems kind of drastic!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gysmo38/mitsubishi2MQTT/pull/101#pullrequestreview-491165928, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVCNGH7RHLNJFHQE7MVL4DSGLXW7ANCNFSM4QWALPFA .

melyux commented 3 years ago

But what is the purpose of the delay?

melyux commented 3 years ago

That delay doesn't seem to fix the turning off issue. Mine turns off anyway by itself sometimes.