Implement (real) action state

[melyux]

I've (re-)added the action state to the /state topic. It uses the existing but unused operating boolean and the current mode to determine the correct action name. The existing "action" state was just a copy of the "mode" to make Home Assistant happy, but after this change will actually reflect whether the compressor/pump is working (in the cooling/heating states). I've tested it on my unit and it's working so far, but it's a cooling-only model. Should fix #95

[mamrai1]

@melyux please check pull request 102!! i think i does the same thing

[melyux]

@mamrai1 Great minds think alike! Do you want to go for my PR because it also fixes the dummy packet sending for the fan_only mode, the unnecessary result variable assignment, also works for auto, and doesn’t expose “operating” because “action” already has the same logic?

[mamrai1]

Yes of course... I will test it tomorrow

On Tue, 8 Sep 2020, 19:51 melyux, notifications@github.com wrote:

@mamrai1 https://github.com/mamrai1 Great minds think alike! Do you want to go for my PR because it also fixes the dummy packet sending for the fan_only mode, the unnecessary result variable assignment, also works for auto, and doesn’t expose “operating” because “action” already has the same logic?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gysmo38/mitsubishi2MQTT/pull/103#issuecomment-689006988, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVCNGE7QR4TNXWOZTLUFJTSEZOKXANCNFSM4Q5V57BQ .

[mamrai1]

I had time tonight and checked it. works ok with both of my units and HA. Nice!

[gysmo38]

Thanks