Closed lesleypersyn closed 3 years ago
Thanks :)
This was already fixed with #105, and this merge conflicts with that fix and messes things up again. This PR needs to be reversed @gysmo38.
Please check when merging multiple pending PRs because multiple people try to fix the same thing at the same time (happened last time too).
Hmm not sure what you mean. Am I sure this is fixed by the other one? Yes. In fact, this PR as it is will convert your set temperature from Fahrenheit... into Fahrenheit, causing monstrous temperature settings like 169°F when you wanted 76°F.
@melyux ok thank you. I think it is ok now :)
@gysmo38 I think you may have closed your revert PR for some reason, unless I’m missing something. The code is still showing the results of this PR.
@gysmo38 This change still needs to be undone, the current code is in an incorrect state
@melyux if you can made a new PR to correct what is undone, it simplest for me.
@gysmo38 Done! #112
fix for Temperature set in Home Assistant bounces to default value #106