search

gysmo38 / mitsubishi2MQTT

Mitsubishi to MQTT with ESP8266 module
GNU Lesser General Public License v2.1
390 stars 139 forks source link

Update mitsubishi2mqtt.ino #108

Closed lesleypersyn closed 3 years ago

lesleypersyn commented 3 years ago

fix for Temperature set in Home Assistant bounces to default value #106

gysmo38 commented 3 years ago

Thanks :)

melyux commented 3 years ago

This was already fixed with #105, and this merge conflicts with that fix and messes things up again. This PR needs to be reversed @gysmo38.

Please check when merging multiple pending PRs because multiple people try to fix the same thing at the same time (happened last time too).

melyux commented 3 years ago

Hmm not sure what you mean. Am I sure this is fixed by the other one? Yes. In fact, this PR as it is will convert your set temperature from Fahrenheit... into Fahrenheit, causing monstrous temperature settings like 169°F when you wanted 76°F.

gysmo38 commented 3 years ago

@melyux ok thank you. I think it is ok now :)

melyux commented 3 years ago

@gysmo38 I think you may have closed your revert PR for some reason, unless I’m missing something. The code is still showing the results of this PR.

melyux commented 3 years ago

@gysmo38 This change still needs to be undone, the current code is in an incorrect state

gysmo38 commented 3 years ago

@melyux if you can made a new PR to correct what is undone, it simplest for me.

melyux commented 3 years ago

@gysmo38 Done! #112