search

gysmo38 / mitsubishi2MQTT

Mitsubishi to MQTT with ESP8266 module
GNU Lesser General Public License v2.1
375 stars 134 forks source link

Added support for MQTT LWT (status) messages #117

Closed ghost closed 2 years ago

ghost commented 3 years ago

This pull request adds support of birth and LWT (last will / status) messages for MQTT, also configuring them through Home Assistant MQTT Discovery. It lets Home Assistant know when A/C is not available for control.

mamrai1 commented 3 years ago

I have tried your patch but after a while I see N/A values in HA climate...

ghost commented 3 years ago

I have tried your patch but after a while I see N/A values in HA climate...

Hmm... these exact changes didn't cause such strange behaviour when they were applied on a bit older version (approx. May or June 2020). Could you please attach a screenshot of entity attributes and control card? Will investigate at weekend.

mamrai1 commented 3 years ago

Yes, indeed... i have also reverted the code before #105 fixes and works as expected..it's been running on 2 units since yesterday and everything looks ok..

gysmo38 commented 3 years ago

it still necessary to merge this change?

lesleypersyn commented 3 years ago

it still necessary to merge this change?

yes, please. Thanks!

chrisallen commented 3 years ago

Is there anything left before this can be merged? It would be nice for Home Assistant to know when A/C is not available for control.

melyux commented 3 years ago

@gysmo38