gysmo38 / mitsubishi2MQTT

Mitsubishi to MQTT with ESP8266 module
GNU Lesser General Public License v2.1
375 stars 134 forks source link

Changed =='\0' to .isEmpty() in multiple lines Resolves issue #145 #146

Closed techmagellc closed 2 years ago

techmagellc commented 3 years ago

Change is needed to allow compile under gcc >=3.0

juampe commented 2 years ago

To compile again please use @2.6.3 pio espressif8266 framework

[env:WEMOS_D1_Mini]
platform = espressif8266 @2.6.3
board = d1_mini
framework = arduino
lib_deps = ${common.lib_deps_ext}
monitor_speed = 115200
upload_speed = 460800
scottmmjackson commented 2 years ago

@juampe that workaround does not work.

The PR fixes the issue. Is there a reason it can't be merged?

juampe commented 2 years ago

@scottmmjackson sorry but I don't have permissions to commit in this repository, I only provide a "forzen in time" workaround. That last activity in this repo was in 24 Feb. I have submited PR in the past and was accepted. @gysmo38 Are you OK? PD I think that it will an interesting thing continue the development process in another fork. I'm already interested to test some new functionalities.

gysmo38 commented 2 years ago

Thank you :)