Closed shampeon closed 4 years ago
Added https://github.com/gysmo38/mitsubishi2MQTT/pull/23 to fix this issue.
Fixed with #23.
@gysmo38 Your latest commit (https://github.com/gysmo38/mitsubishi2MQTT/commit/6391f332991ab0dbc1afa11b935481d7e826546e) overwrote all the Fahrenheit code you merged in with #23.
Ok sorry about that. I maybe made a mistake. I will put your code again.
I push a new commit with your Fahrenheit code :) Hope it is ok now.
Ok, thanks.
Spoke too soon, you forgot the HA config templates that were altered to support F. Fixed in #24.
Thank you for your PR. I have the idea to add a Unit menu under Setup. In this page we will able to choose between metrecis and fahrenheit.
Unlike an HA custom component, which can set the display scale to follow the unit system of HA, an autodiscovered MQTT hvac device can't be configured to use Fahrenheit to display and set the temperature. HA assumes that all devices follow the scale set if you set
unit_system
in your configuration.Since I live in the US, installing mistsubishi2MQTT displays the climate component in HA as if the values were Fahrenheit when they are actually Celsius.
The code assumes the use of metric scale, probably since the SwiCago library and the Mitsubishi units themselves use Celsius internally.
The sketch should have a configurable option for displaying and processing Fahrenheit values and converting them to and from Celsius when interacting with the SwiCago library.