gytis-ivaskevicius / high-quality-nix-content

GitHub repository containing highest quality Nix/NixOS content
MIT License
296 stars 19 forks source link

Store images as webp, use Git LFS, or consider rewriting history over time. #4

Closed MatthewCroughan closed 3 years ago

MatthewCroughan commented 3 years ago

Since we're storing binary information, we should either use Git LFS (Maybe even pin using IPFS). Although, if we insist on keeping this simple and having a git repository here, there are two immediate things we can do to improve the situation:

The history of commits on this repository are not useful, since we have creators.nix which gives credits, commits are not needed.

gytis-ivaskevicius commented 3 years ago

Git LFS/IPFS does not bring any value for this particular case since images are added and never changed thus there is no Git overhead.

As for image format - I am down for changing it but unfortunately, not everything accepts webp file format which will likely become an inconvenience for lots of peeps. So basically here is file format requirements:

MatthewCroughan commented 3 years ago

@gytis-ivaskevicius Why should we care about what Internet Explorer 7 supports? The fact of the matter is that most browsers support webp, apng, etc. These are new technologies, so we shouldn't be afraid to use them and proliferate their usage, especially in a repository like this which is designed for fun.

gytis-ivaskevicius commented 1 year ago

There are cases where you are not able to upload webp, so if a user wishes to use it as let's say profile picture it may cause problems. Also, I like the idea of using images of original quality even though it's likely that nobody would notice the difference. Feel free to implement some auto-conversion mechanism, I am not against it