search

gyunaev / birdtray

new mail system tray notification icon for Thunderbird
GNU General Public License v3.0
782 stars 59 forks source link

Fix Windows installer build #561

Closed Abestanis closed 10 months ago

Abestanis commented 10 months ago

This pins the NSIS version, because newer version break our nsis scripts. I tested that this works on a fork.

After merging this we should either create a new version or delete the tag of the current latest version and push a new tag.

Fixes #560.

Abestanis commented 10 months ago

@gyunaev can you either create a new version or delete the tag of the current latest version and push a new tag?

gyunaev commented 10 months ago

Retagged as 1.11.1.

Abestanis commented 10 months ago

Looks like the CI created a release as a Draft with the installers attached, but you also created a release manually without them. Can we just remove the manually created release an undraft the automatically generated one?

gyunaev commented 10 months ago

Done.

Abestanis commented 10 months ago

Thanks, we forgot to increase the patch version, but it's fine, we'll do it the next release. We should create a wiki page on how to do a release, so we don't forget for next time 😄

MChaos45 commented 10 months ago

The update is reported as 1.11.2, but the download is 1.11.0.

But there's a bigger problem (on my machine, 64 bit Windows 10) is that the 32 bit installer works fine, but the 64 bit installer doesn't work (nothing happens, just shows up in task manager for a few seconds, but no window or error message).