search

gyunaev / birdtray

new mail system tray notification icon for Thunderbird
GNU General Public License v3.0
792 stars 60 forks source link

Allow to remove account folder with Delete or Backspace keystroke #588

Closed MathiusD closed 7 months ago

MathiusD commented 7 months ago

When you have a large number of accounts/folder to monitor, it's quite useful to enable deletion with a keystroke on the keyboard instead of clicking a button, so this PR is made for that.

MathiusD commented 7 months ago

I think this is a good idea, I just have an alternative proposal for the QTreeViewWithKeyEvents class.

Also, should we make the keyboard shortcut more discoverable? We could add a tooltip to the delete button that mentions the keyboard shortcuts.

Yes i can had a tooltip in another PR !

How about we just use the Qt event system instead of building our own, that way we can avoid some casts and manually storing listeners.

Yes, i have search if such signal exist in qt component and because i doesn't exist i have had own listener and i admit i've don't think to reuse signal system, i can follow your recommandation in another PR (Because it's already merged) !