search

gyunaev / karlyriceditor

lyrics editor and CD+G/video exporter for Karaoke
http://www.ulduzsoft.com/linux/karaoke-lyrics-editor/
GNU General Public License v3.0
59 stars 16 forks source link

Updated playerwidget code #29

Open dwRchyngqxs opened 3 months ago

dwRchyngqxs commented 3 months ago

Fix many slider strange behaviour by reimplementing it. Time is updated correctly. Moving the slider displays the target time in a tooltip.

Inserting a timestamp uses current time, especially when paused. Empty timestamps when paused is annoying and they can be easily typed in anyways if needed.

dwRchyngqxs commented 3 months ago

I think adding empty timestamp should be a feature separated from adding a timestamp.

gyunaev commented 3 months ago

So far looks good to me.

gyunaev commented 3 months ago

I think adding empty timestamp should be a feature separated from adding a timestamp.

This would change existing behavior which current users hate, but you can add an additional option for this.

dwRchyngqxs commented 3 months ago

The reasoning behind using the [--:--] timestamps is to be able to streamline placing timestamps: After one timestamp is placed the cursor jumps to the next timestamp, so while playing a song it is possible to just press the insert timestamp button without having to move the cursor to the right position in the text. This works well with inserting several empty marks where the flow of a line should be altered after testing a section. So I understand why we should provide the ability to insert empty marks while paused. This addition can be done in a separate PR.

For this PR, I need to check the code and uses of isPaused. I think it is no longer testing whether the player is paused.