gz / rust-cpuid

cpuid library in rust.
https://docs.rs/raw-cpuid/
MIT License
147 stars 43 forks source link

CpuId reader trait and serialize feature fix #140

Closed gz closed 1 year ago

gz commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #140 (2d13588) into master (a837dba) will increase coverage by 2.12%. The diff coverage is 36.36%.

:exclamation: Current head 2d13588 differs from pull request most recent head aab103c. Consider uploading reports for the commit aab103c to get more accurate results

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   39.34%   41.46%   +2.12%     
==========================================
  Files           4        4              
  Lines        4072     3849     -223     
==========================================
- Hits         1602     1596       -6     
+ Misses       2470     2253     -217     
Impacted Files Coverage Δ
src/bin/cpuid.rs 5.55% <0.00%> (+1.20%) :arrow_up:
src/display.rs 0.00% <0.00%> (ø)
src/extended.rs 85.71% <ø> (+2.35%) :arrow_up:
src/lib.rs 52.32% <52.83%> (+1.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mkeeter commented 1 year ago

This looks good to me!

gz commented 1 year ago

Thanks for taking a look! I think the remaining thing I'm not sure about yet is if the default argument with NativeCpuIdReader is a good idea (if done solely for x86). Maybe I'll write some code examples later on the mac and see how weird it gets.

gz commented 1 year ago

Ok so better late than never... I'm going to merge this now and release v11.

I did remove the default generic argument again, because even without it I don't think it's too bad for migration for users to v11.

mkeeter commented 1 year ago

Thanks for merging this in! Can you please push a release to crates.io as well, so we can update our dependencies?

gz commented 1 year ago

Just released v11