search

gz / rust-x86

Rust library to use x86 (amd64) specific functionality and registers.
https://docs.rs/x86
MIT License
303 stars 63 forks source link

Fix asm syntax of some VMX instructions #122

Closed equation314 closed 2 years ago

gz commented 2 years ago

Thanks! I wonder if there is something you're running this code with that we can use to test the x86 crate in the future (as I'm not actively using this code it's hard to test it :))?

equation314 commented 2 years ago

I use this crate in our hypervisor project https://github.com/rcore-os/RVM1.5. It won't work after upgrading the crate to v0.45.0. You can see the difference between v0.44.0 and v0.45.0 in the disassembled code.

gz commented 2 years ago

Thanks, released as 0.46.0

dancrossnyc commented 2 years ago

Oops; my bad. Sorry, I didn't have an easy means to test that, either. (I really need to put together that Xeon test box....)

gz commented 2 years ago

no worries, it's just the sgx and vmx code that's not really covered well by what I'm running I think, but it's great to see that others are using it and finding the bugs quickly!