gzdwsu / RaiderSMA

Murphy's Wrestling Tournament Manager. Design of Info Tech Sys. Secondary Project.
1 stars 17 forks source link

Changing getLongString() method in SoccerPlayer.java to use StringBuffer #39

Open nathan-berry opened 4 years ago

nathan-berry commented 4 years ago

Location: src/DataClasses/SoccerPlayer.java

Deficiency: The way strings are being used is anti-memory management friendly and will cause memory loss.

Reason: This is the same issue tackled in Wrestler.java by me and my partner for project 1 submission, James Wright. String literal usage like found in lines 78-84 cause memory loss over time, as the string literals do not leave memory until the program completely finishes execution and closes. If the program was used for a massive amount of players, this would cause issues very quickly.

nathan-berry commented 4 years ago

I am claiming this issue.