search

gzuidhof / starboard-notebook

In-browser literate notebooks
Mozilla Public License 2.0
1.24k stars 99 forks source link

Bump pyodide version to 0.25.0 #141

Closed bartbroere closed 8 months ago

bartbroere commented 1 year ago

Bumping the Pyodide version. Seems to work okay, except the .isPyProxy() method now shows a deprecation warning.

TODO:

bartbroere commented 9 months ago

The monorepo approach makes it a bit hard to test this, because it really likes to use old versions from npm, instead of the version it just built.

bartbroere commented 9 months ago

The monorepo approach makes it a bit hard to test this, because it really likes to use old versions from npm, instead of the version it just built.

I got it going by doing a yarn add ../starboard-python in the packages/starboard-notebook directory. This shows me that it works:

image

As the CI currently runs it will build each package individually but it will not test the combination of the newly built packages, since starboard-notebook gets built with the NPM release of starboard-python and starboard-rich-editor. I needed to add the artifact upload in the CI to come to that conclusion. What gives it away is that it still pulls the 0.20.0 release of Pyodide from jsdelivr.net.

This pull request is in working order though.

gzuidhof commented 8 months ago

Thank you 🙏