search

gzuidhof / starboard-notebook

In-browser literate notebooks
Mozilla Public License 2.0
1.24k stars 99 forks source link

Building 14.1 #70

Closed twoxfh closed 3 years ago

twoxfh commented 3 years ago

I am working on creating a devcontainer for building starboard, however I am running into an issue. with typescript below. Any suggestions?

image

gzuidhof commented 3 years ago

I'm not sure why this is happening, this bit of that file should tell Typescript that the manager object is present in the global scope.

We can add // @ts-ignore above the lines with the problems to get it to build, but of course it's better if we don't have to do that :/. I guess there is some error in the typescript config or an incompatibility with typescript versions.

twoxfh commented 3 years ago

// @ts-ignore works and now the project builds. Let me know if you want it as a pull request. Also let me know if you want a .devcontainer pull request for the project as well.

twoxfh commented 3 years ago

If you change WorkerGlobalScope to Window, it works. However with the newer version of Typescript there are other syntax errors in that file.

image

image

@gzuidhof not sure of the ramifications of changing the code to Window and proper fixes for the others, I am able to build and try things out so I will close the issue.