FW: simplify Ethernet activation

gzweigle / open-hybrid-piano

Building a hybrid MIDI digital piano

https://www.youtube.com/@gzpiano88

GNU General Public License v3.0

43 stars 2 forks source link

Closed davidedelvento closed 1 month ago

davidedelvento commented 2 months ago

According to https://github.com/stem-piano/stem-piano-g-main/blob/main/documentation/users_manual.md#ethernet ethernet data is sent when a key is held and pedal depressed. I see two problems with this approach:

Can (and will!) be triggered involuntarily when playing. Probably not a bit deal, but still cycles wasted if unintended
Hard to trigger during testing when pedal may not be available

I recommend switching to a procedure that uses ETHERNET_SEND_KEY as it is done for the damper board

gzweigle commented 1 month ago

The software now sends all 96 analog inputs all the time.

I made a YouTube video showing the new functionality -