suggestions related to DataFrames.jl

h-Klok / StatsWithJuliaBook

https://statisticswithjulia.org/

MIT License

1.08k stars 279 forks source link

Closed bkamins closed 5 years ago

bkamins commented 5 years ago

Hi @h-Klok,

I have made some suggestions to your codes. Please feel free to accept or reject them. The changes are related to:

not using deprecated functionality
avoiding functionality that might change in the future
some code clenup (how I would write things - but of course this is a matter of taste) => the main changes of this kind are in dataframeImputation.jl and scatterplot.jl in chapter 4

All the best with your book!

CC @nalimilan

h-Klok commented 5 years ago

Hi @bkamins and @nalimilan, Thank you very much for your excellent suggestions, they are much appreciated and definitely worth incorporating!

bkamins commented 5 years ago

@h-Klok - you are welcome 😄. And all the best with your book.