h-REA / hREA

A ValueFlows / REA economic network coordination system implemented on Holochain and with supplied Javascript GraphQL libraries
https://docs.hrea.io
Other
143 stars 15 forks source link

After release of the first HDI (or integrity kit) of Holochain, update versions to that #275

Closed Connoropolous closed 2 years ago

Connoropolous commented 2 years ago

here is an example to sample from: https://github.com/perspect3vism/agent-language/tree/main/hc-dna/zomes/tests

pospi commented 2 years ago

This will be quite an extensive refactor- we will need to update all the index handling logic to use split integrity/coordination zomes to manage the updates via post_commit hooks. In doing so it is hoped that such cascading updates can be handled more gracefully, and debug! statement related to indexing removed.

We may also have to update tests unrelated to Agent data but featuring Agent links to actually create the agents in question. Currently the indexing situation swallows / ignores many CellMissing errors that are related to mocked AgentAddresses.

Connoropolous commented 2 years ago

"we will need to update all the index handling logic to use split integrity/coordination zomes to manage the updates via post_commit hooks. In doing so it is hoped that such cascading updates can be handled more gracefully, and debug! statement related to indexing removed."

This sounds like added scope. Unless I'm missing something which is very possible, this sounds like something unnecessary to do at this same time. Can we trim back this scope to only the update?

I am thinking of targeting HDK 0.0.142 HDI 0.0.14

And thats Holochain 0.0.150

Connoropolous commented 2 years ago

"We may also have to update tests unrelated to Agent data but featuring Agent links to actually create the agents in question. Currently the indexing situation swallows / ignores many CellMissing errors that are related to mocked AgentAddresses."

I also don't think we will have to do this.

pospi commented 2 years ago

Yeah, two phases for these updates I think.

Connoropolous commented 2 years ago

@pospi I've started this, and have assigned it to myself for now, but am also happy to collaborate on it, we would just need to coordinate our actions.

Connoropolous commented 2 years ago

There is this one to review: https://github.com/holochain-open-dev/dna-auth-resolver/pull/3 and this one is up and just getting started in draft: https://github.com/h-REA/hREA/pull/340