search

h-REA / hREA

A ValueFlows / REA economic network coordination system implemented on Holochain and with supplied Javascript GraphQL libraries
https://docs.hrea.io
Other
143 stars 15 forks source link

update the Plan DNA and tests with `plannedWithin` field that was previously missing #278

Closed Connoropolous closed 2 years ago

Connoropolous commented 2 years ago

@pospi I think this is contingent on you or I adding plannedWithin to CreatePlanParams and UpdatePlanParams over in v-graphql, agreed?

pospi commented 2 years ago

No, those fields aren't writable via Plan. The relationship on that side is processes- what needs to be checked is that creating a Process.plannedWithin updates the reciprocal index Plan.processes, and that both sides of the query return the correct results.

Connoropolous commented 2 years ago

Ah. I expressed this wrong, sorry.

I meant to be referring to Commitment and its relationship with Plan. That is the plannedWithin that I was concerned with, and we (Wesley and I) were wondering if it shouldn't be the case that CommitmentCreateParams and CommitmentUpdateParams should have the plannedWithin field, which appears to be missing: https://lab.allmende.io/valueflows/vf-schemas/vf-graphql/-/blob/sprout/lib/schemas/bridging/commitment.plan.gql#L29-37

Connoropolous commented 2 years ago

@fosterlynn you also might be able to help us on this?

fosterlynn commented 2 years ago

we (Wesley and I) were wondering if it shouldn't be the case that CommitmentCreateParams and CommitmentUpdateParams should have the plannedWithin field, which appears to be missing

Makes sense to me.

Connoropolous commented 2 years ago

Ok that being the case I submitted a PR here, and requested @pospi review on it. Thanks @fosterlynn https://lab.allmende.io/valueflows/vf-schemas/vf-graphql/-/merge_requests/107

pospi commented 2 years ago

Done! 0.9.0-alpha.5 now published

Connoropolous commented 2 years ago

@weswalla this is actionable now. There's a release of vf-graphql (0.9.0-alpha.5) that Pospi just did, that if updated to, contains the plannedWithin field for CreateCommitmentParams and UpdateCommitmentParams.