h-REA / hREA

A ValueFlows / REA economic network coordination system implemented on Holochain and with supplied Javascript GraphQL libraries
https://docs.hrea.io
Other
142 stars 15 forks source link

More flexible index macros to allow String-based identifiers for agent_type #333

Closed pospi closed 2 years ago

pospi commented 2 years ago

This should help with #326. All Agent tests seem to be passing, but I haven't checked the status of them to see which parts of the behaviour they're exercising. Merge when you feel happy with this approach.

Now closes #330 in addition to enabling agent_type to work.

pospi commented 2 years ago

hey, cool! This is the error I was expecting to be getting and confused as to why I wasn't. I think I just need to move a little more code away from the Agent-specific stuff and put it into the core libraries. And change some calling signature somewhere to line up that changed field.

pospi commented 2 years ago

@Connoropolous @weswalla should be good to merge now. If I do any more work to support UnitId in this branch I'll leave it local-only until I've confirmed the units readall test is working.

pospi commented 2 years ago

Units working now as well (: