search

h-REA / hREA

A ValueFlows / REA economic network coordination system implemented on Holochain and with supplied Javascript GraphQL libraries
https://docs.hrea.io
Other
142 stars 15 forks source link

Feature/220 ordered query apis #336

Closed pospi closed 1 year ago

pospi commented 1 year ago

MVP of ordering of filtered resultsets from search APIs.

All tests hopefully passing, but might be a few orderings to clear up still. Otherwise looks to be working well for use with baseline functionality.

Closes #331 but will also need to log a followup job to improve this later for alignment with original record creation times.

pospi commented 1 year ago

So looks like some small errors to clear up in conforming_resources.js (which seems simple) and in resource_logic.js (which is mildly worrying but hoping it's just a mismatched ID)

pospi commented 1 year ago

Two remaining errors in the new plan tests you added recently @Connoropolous - care to investigate? Probably just ordering related or maybe a merge needs to be made.

Connoropolous commented 1 year ago

@pospi I think a line that assigned a value to variable processes got removed here: https://github.com/h-REA/hREA/commit/90eb6a548b1962e700b0b24cefd0fafbc9ed8215#diff-222e219b24cfa0c22508edb248e1b19176f736760f7c485da1704494e823098bL158

and that is the source of the failing assertion

Connoropolous commented 1 year ago

I've just pushed a fix for it, I think.