stringIdRegex for Unit symbols is not loose enough for something like `$`

h-REA / hREA

A ValueFlows / REA economic network coordination system implemented on Holochain and with supplied Javascript GraphQL libraries

https://docs.hrea.io

Other

143 stars 15 forks source link

stringIdRegex for Unit symbols is not loose enough for something like `$` #354

Closed Connoropolous closed 2 years ago

Connoropolous commented 2 years ago

https://github.com/h-REA/hREA/blob/067ee13467a304140ca62deec084d7a4cfa7c6dc/modules/vf-graphql-holochain/connection.ts#L142

this regex doesn't pick up, and thus doesn't deserialize for zome calls, a Unit ID which is specified via an actual 'symbol' symbol, instead of a string. @pospi I am guessing this is not intentional

pospi commented 2 years ago

correct! That's an oversight. I guess a nongreedy match-all then?

Connoropolous commented 2 years ago

we could prevent matching digits, and that's it maybe