h-a-graham / rayvista

An R plugin for {rayshader} to view a 3D vista anywhere on earth.
GNU General Public License v3.0
107 stars 5 forks source link

Error in if (file.exists(over_cache) && file.exists(bbox_cache)) #12

Closed econpulse closed 3 years ago

econpulse commented 3 years ago

Hi there, I updated to version 0.1.3 and both on my Ubunto 20.04 and Windows 10 machines rayvista is not working anymore. I get the above error message just by running the sample from the plot_3d_vista example from the documentation. Many thanks in advance for having a look at it.

Here's the output of my sessioninfo:

R version 4.0.4 (2021-02-15)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19042)

Matrix products: default

locale:
[1] LC_COLLATE=German_Switzerland.1252  LC_CTYPE=German_Switzerland.1252   
[3] LC_MONETARY=German_Switzerland.1252 LC_NUMERIC=C                       
[5] LC_TIME=German_Switzerland.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] rayvista_0.1.3   rayshader_0.23.0

loaded via a namespace (and not attached):
 [1] rgl_0.105.22            Rcpp_1.0.6              prettyunits_1.1.1       class_7.3-18           
 [5] ps_1.6.0                utf8_1.2.1              assertthat_0.2.1        rprojroot_2.0.2        
 [9] digest_0.6.27           foreach_1.5.1           mime_0.10               R6_2.5.0               
[13] e1071_1.7-4             ggplot2_3.3.3           pillar_1.5.1            rlang_0.4.11           
[17] progress_1.2.2          curl_4.3.1              rstudioapi_0.13         miniUI_0.1.1.1         
[21] callr_3.5.1             desc_1.3.0              devtools_2.3.2          webshot_0.5.2          
[25] htmlwidgets_1.5.3       munsell_0.5.0           shiny_1.6.0             vipor_0.4.5            
[29] compiler_4.0.4          httpuv_1.5.5            xfun_0.22               pkgconfig_2.0.3        
[33] pkgbuild_1.2.0          ggbeeswarm_0.6.0        htmltools_0.5.1.1       tidyselect_1.1.0       
[37] tibble_3.1.0            codetools_0.2-18        fansi_0.4.2             crayon_1.4.1           
[41] dplyr_1.0.5             withr_2.4.1             later_1.1.0.1           sf_0.9-7               
[45] grid_4.0.4              gtable_0.3.0            jsonlite_1.7.2          xtable_1.8-4           
[49] lifecycle_1.0.0         DBI_1.1.1               magrittr_2.0.1          scales_1.1.1           
[53] units_0.7-0             KernSmooth_2.23-18      cli_2.3.1               cachem_1.0.4           
[57] fs_1.5.0                promises_1.2.0.1        remotes_2.2.0           doParallel_1.0.16      
[61] testthat_3.0.2          ellipsis_0.3.1          vctrs_0.3.6             generics_0.1.0         
[65] iterators_1.0.13        tools_4.0.4             manipulateWidget_0.10.1 beeswarm_0.3.1         
[69] glue_1.4.2              purrr_0.3.4             hms_1.0.0               crosstalk_1.1.1        
[73] processx_3.4.5          pkgload_1.2.0           parallel_4.0.4          fastmap_1.1.0          
[77] colorspace_2.0-0        sessioninfo_1.1.1       classInt_0.4-3          memoise_2.0.0          
[81] knitr_1.31              usethis_2.0.1          
h-a-graham commented 3 years ago

Rats, I may have rushed something out too quick. I was trying to improve the handling of cached data. Can you try specifying a folder with the cache_dir argument, please? It should create the folder for you now...

Thanks for this!

h-a-graham commented 3 years ago

So I think I've patched this now. Stupid me put the return inside the check for thunderforest data sources and so unless you requeste thunderforest it was returning NULL: https://github.com/h-a-graham/rayvista/commit/31eabbb3d6e4297dff4f742fedafc9c2d159799d

Can you restart you R session, reinstall and let me know if things are working again please? Sorry for the inconvenience and thanks again for letting me know!

econpulse commented 3 years ago

Perfect, this solved the issue, it's working now again. Many thanks!