h-tadagawa / rest-client

Automatically exported from code.google.com/p/rest-client
Apache License 2.0
0 stars 0 forks source link

Feature Request: Request Timeout Setting #46

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
It'd be useful if I could specify a request timeout setting in the preferences. 
Not sure what the 
default should be, but it should be possible to enter 0 to indicate no timeout.

Original issue reported on code.google.com by aviflax on 5 Mar 2008 at 10:08

GoogleCodeExporter commented 8 years ago
Or, maybe instead of entering zero to indicate no timeout, the entire setting 
should probably have a checkbox, 
to indicate whether a timeout should be in effect at all.

Original comment by aviflax on 5 Mar 2008 at 10:09

GoogleCodeExporter commented 8 years ago
API to use:

HTTPClient client = ...
HTTPConnectionParams params = client.getHttpConnectionManager().getParams();
params.setConnectionTimeout(int);

The timeout is in milliseconds. For 2.1 release I will set a default timeout of 
1
minute (60,000 milliseconds == 1 minute). Future versions will have this as a
configuration parameter.

Original comment by subwiz on 6 Mar 2008 at 1:15

GoogleCodeExporter commented 8 years ago
Rev. 153 incorporates the changes for 2.1 version. Build incorporating this 
feature
is available here:

http://wiztools.org/project/RESTClient/restclient-2.1-SNAPSHOT-jar-with-dependen
cies.jar

This is to be tested in a slow responding server (which takes more than 1 
minute). If
it takes more than 1 minute, the connection should be reset at the RESTClient 
side
(instead of freezing RESTClient as previously).

Original comment by subwiz on 6 Mar 2008 at 4:11

GoogleCodeExporter commented 8 years ago
Subhash, that's good progress, but having a timeout without any way to disable 
it, or change the setting, is 
actually worse for me than not having a timeout at all. I frequently have 
services which take more than 60 
seconds to respond to a request, even when there are no problems or issues at 
all. So, my vote is to only 
include this feature when it can have at least a way to disable it.
Thanks,
Avi

Original comment by aviflax on 7 Mar 2008 at 4:27

GoogleCodeExporter commented 8 years ago
Oh, Ok. So I will remove this for 2.1 release. For the next release we will 
have a
configuration option.

Original comment by subwiz on 7 Mar 2008 at 5:17

GoogleCodeExporter commented 8 years ago
Revision 170 has the UI changes. The functionality is not yet done: more 
refactoring
needs to be done to make the OptionsDialog more extensible, after that the
functionality will be added.

Original comment by subwiz on 14 Mar 2008 at 3:35

GoogleCodeExporter commented 8 years ago
Revision 177 has the fix.

Original comment by subwiz on 17 Mar 2008 at 10:27