h-v-smacker / canned_food

Canned fruits/vegetables, and jams for Minetest game
GNU Affero General Public License v3.0
1 stars 3 forks source link

Blueberry jam recipes are reversed #5

Closed hlqkj closed 3 weeks ago

hlqkj commented 3 years ago

The wild/normal blueberry jam and blueberry kind are mixed:

Not such important but worth fixing, since I've had a few players noting this.

EDIT: added link.

h-v-smacker commented 3 years ago

I don't think I understand your issue here. There are two kinds of jam. One is made with berries from cubic bushes. The other with berries from small plants growing on farming soil. They produce different items, hence different jams.

hlqkj commented 3 years ago

The issue is the 2 recipes are reversed. The normal jam requires "wild" berries, and the wild jam recipe requires "normal" berries. Sorry if my first comment wasn't so clear, I'm not english...

h-v-smacker commented 3 years ago

Well... my logic is as follows: the square bushes are more fitting the description of "wild" berries: large bushes, no special soil or water needed. Meanwhile, the small bush blueberries need farming soil to grow, so they are more like "domestic" or "garden" variety (except when you find them in the wild, but then again, most people use those found berries as seeds).

hlqkj commented 3 years ago

I am reporting this here only because I've got some players reporting it to me. Your logic makes sense actually, but what I see is confusing for the players is the items displayed names.

I'm posting two screenshots to show what I mean, then I'll drop this discussion, so feel free to close it if it doesn't make sense to you (the text over the craft grid is from the mouse tool-tip which appears on hovering).

Screenshot 2021-08-04 110048 Screenshot 2021-08-04 110125

h-v-smacker commented 3 years ago

Aha, now I see — you see, I largely ignore the proper item names, since I'm not a new player and have no reason to explore the game. I gotta think on this though, since my initial logic (see above) was connected to the way the berries are obtained, not their names.

hlqkj commented 3 years ago

I see your point too and it makes great sense: I didn't think at that at first. Have to admit, the confusion actually originates in the farming mod where they termed a cultivated crop as 'wild'. That choice may have been made just to distinguish them from the default ones — which are the real wild ones.

We may try to point out the issue in the farming repo instead? The reason could be that the 'wild' adjective doesn't make sense since they can be farmed.

EDIT: actually, just renaming farming:blueberries would not completely solve this: we would still be having the "Wild bueberry jam" made with "Blueberries" from the default mod, which 99% will not change I'm afraid...

h-v-smacker commented 3 years ago

I think petitioning tenplus1 to rename blueberries from "wild" into "garden" or something would do nicely. As for the remaining part of the scheme, I don't think that it would cause as much confusion when we have "wild bb jam" made from "blueberries" and "bb jam" made from "garden blueberries". Well, it would be nice to have the default blueberries renamed into wild bbs, but I think reaching farming mod's dev is far easier.

hlqkj commented 3 years ago

Closing because I doubt that neither minetest_game and farming will consider such a change, in reality they should both find a coherent convention and apply it. In any case I'd like to thank you for considering this issue at first :)

h-v-smacker commented 3 years ago

I dunno about that. Let's see what TenPlus1 would think about it: https://notabug.org/TenPlus1/farming/issues/58

tenplus1 commented 3 years ago

In the jam recipe why not use the {food_blueberries=1} group instead of an actual item, that way both kinds of blueberries can be used for the same recipe. e.g. https://notabug.org/TenPlus1/farming/src/master/crops/blueberry.lua#L23

hlqkj commented 3 years ago

That could be a solution but would force @h-v-smacker waiving his idea of having two jams. Even in that case, though, the oddity would remain: a wild specie is by definition something that can't be grown artificially, or which is so difficult to grow that it's de facto considered not cultivable.

The ideal would be having farming:blueberries called 'Blueberries' and having default:blueberries called 'Wild blueberries' instead (even the inventory images would match better, since wild blueberries are smaller and more dense than cultivated one -- see on the internet) but sadly minetest_game development seem to be frozen now...

h-v-smacker commented 3 years ago

Well, the idea of having two jams is also connected to how the jams are represented: each jar has a sticker on it with the little image of the canned product, and the color for the contents of the jar is also borrowed from that image. A group recipe would make a universal jam (and instead of wild/garden we can have unsweetened/with sugar), but that also means something is to be done with the sticker, or else players can be similarly confused: why a jam made from farmed berries has an image of different berries on it, and vice versa.