search

h0wl / pdfium

Automatically exported from code.google.com/p/pdfium
1 stars 1 forks source link

Check cs->GetRGB() return values in fpdf_page_colors.cpp #44

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The anti-pattern

     m_pAltCS->GetRGB(results, R, G, B);
     return TRUE;

occurs frequently in fpdf_page_colors.cpp.  These should be changed to

     return m_pAltCS->GetRGB(results, R, G, B);

to propagate errors to callers.

Original issue reported on code.google.com by tsepez@chromium.org on 21 Aug 2014 at 10:53