search

h0wl / pdfium

Automatically exported from code.google.com/p/pdfium
1 stars 1 forks source link

Feature: Figure out a smart-pointer class strategy for pdfium #55

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The codebase is badly in need of a unique_ptr and shared_ptr equivalent.  We 
should determine if we are going to use chromium's classes from base/, or if we 
are going to go with the c++11 library, or if we are going to go with something 
else.

Original issue reported on code.google.com by tsepez@chromium.org on 13 Oct 2014 at 11:54

GoogleCodeExporter commented 9 years ago 
Additionally, this implies having  a clear ownership model for memory, using 
the smart pointer classes.  Right now, we kick off a delete at any point in 
time and cascade a bunch of code in an effort to clean up.

Another issue is that ref-counting, where used, is still mostly add-hoc with 
ref increments occurring throughout the code rather than in a smart pointer 
class.

Original comment by tsepez@chromium.org on 28 Oct 2014 at 7:55

GoogleCodeExporter commented 9 years ago 
https://chromium.googlesource.com/chromium/mini_chromium/ may also be of help 
here should we want to use this "base".

Original comment by tsepez@chromium.org on 15 Jan 2015 at 7:36