search

h1alexbel / fakehub

GitHub API Server Stub. Fully functional fake version of a GitHub API that supports all the features and works locally, with no connection to GitHub at all.
MIT License
5 stars 0 forks source link

store data in PostgreSQL database #121

Closed h1alexbel closed 2 months ago

h1alexbel commented 2 months ago

Let's store data in PostgreSQL database instead of XML. This should simplify our flow and get rid of synchronization issues

h1alexbel commented 2 months ago

@l3r8yJ WDYT?

github-actions[bot] commented 2 months ago

@h1alexbel Main quality problem: Lack of specific issue description. Suggestion: Rephrase as a clear problem statement, e.g., "Intermittent synchronization errors occur when using XML storage, consider switching to PostgreSQL database."

h1alexbel commented 2 months ago

@l3r8yJ WDYT?

l3r8yJ commented 2 months ago

@h1alexbel i don't like this idea, because we don't need persist data during the test scenario. As far as I understand, all we need:

  1. Run the tool
  2. Do manipulations with data
  3. Stop the tool

I would rather to have all this data in memory, it will remove all overheads from moving it to psql or xml. In addition, it would be hard to isolate test data in psql for each test that user will run, wdyt?

h1alexbel commented 2 months ago

@l3r8yJ I think we can drop all the data right after tool has been stopped. I fully agree with in-memory solution. Does any in-memory SQL database can be utilized, or you referring to some other in-memory application?

h1alexbel commented 2 months ago

@l3r8yJ I've tested SQLite, check out this pull: https://github.com/h1alexbel/fakehub/pull/123

h1alexbel commented 2 months ago

won't do that: https://github.com/h1alexbel/fakehub/pull/123#issuecomment-2315103122