search

h2non / bimg

Go package for fast high-level image processing powered by libvips C library
https://pkg.go.dev/github.com/h2non/bimg?tab=doc
MIT License
2.65k stars 337 forks source link

Remove dependency on vips7compat #436

Closed der-eismann closed 1 year ago

der-eismann commented 1 year ago

When libvips 8.13 is built with the --disable-deprecated flag, bimg doesn't build anymore because of errors like

# github.com/h2non/bimg
In file included from ./vips.h:5,
                 from vendor/github.com/h2non/bimg/vips.go:5:
/thumbs/include/vips/vips7compat.h:682:1: error: unknown type name 'DOUBLEMASK'
  682 | DOUBLEMASK *im_stats( VipsImage *in );
      | ^~~~~~~~~~
/thumbs/include/vips/vips7compat.h:684:1: error: unknown type name 'DOUBLEMASK'
  684 | DOUBLEMASK *im_measure_area( VipsImage *im,
      | ^~~~~~~~~~

Since im__print_all is the only function being used from vips7compat.h, this shouldn't be an issue.

See https://github.com/libvips/libvips/blob/master/libvips/include/vips/vips7compat.h#L296