h2non / bimg

Go package for fast high-level image processing powered by libvips C library
https://pkg.go.dev/github.com/h2non/bimg?tab=doc
MIT License
2.65k stars 337 forks source link

Use new "keep" option instead of "strip" option #467

Open james-johnston-thumbtack opened 7 months ago

james-johnston-thumbtack commented 7 months ago

It looks like the "strip" option used by bimg here: https://github.com/h2non/bimg/blob/ee92010b9d3f5a0bfb32a00aa302dd80aaea5ea9/vips.h#L327-L333

Was recently deprecated and replaced with a new "keep" option: https://github.com/libvips/libvips/commit/32ddfe702de0617eaaf390ac240e1caf40ba7217#diff-0cdb749283812170ac7d97de48ef99c912116600da659cc717b249eecc350151

It looks like the old "strip" flag is still supported.... for now: https://github.com/libvips/libvips/blob/4cb9da6248e8134050aea7c4adc5d696f5d399d9/libvips/foreign/foreign.c#L1789-L1795

It seems that bimg could consider supporting the new "keep" option for libvips versions that support it.