search

h2non / jsonpath-ng

Finally, a JSONPath implementation for Python that aims to be standard compliant. That's all. Enjoy!
Apache License 2.0
564 stars 85 forks source link

Remove the `coveralls` dependency #138

Closed kurtmckee closed 9 months ago

kurtmckee commented 10 months ago

Coveralls is not used anywhere in the project, and CI isn't configured to use it either.

The package is also outdated; removing it allows coverage to upgrade from v6 to v7.

kurtmckee commented 9 months ago

@michaelmior When you have an opportunity, I think that this PR will prove useful.

Coveralls appears to be unused in the project, but its inclusion in the requirements is imposing costly brute-force version constraint resolution. This problem can be seen in a recent CI run, where pip is working backwards through all of the latest coverage versions until it backtracks all the way to coverage 6.5.0. This backtracking leads to lots of I/O, and a step runtime of over a minute.

Removing the coveralls dependency resolves this backtracking behavior.

I really appreciate your time and effort to review these PRs!

michaelmior commented 9 months ago

@kurtmckee I was hoping to actually get coveralls working again which is why I haven't merged this. Could always pin a version to speed up the CI, but I don't think it's a big issue.

kurtmckee commented 9 months ago

I'm wary of coveralls due to its reliance on third-party Python packages (one of which hasn't had a release in two years, and the other in four years), and because coverall's homepage highlights a repo that hasn't been updated in three years.

image

Would you be open to considering codecov.io instead?

michaelmior commented 9 months ago

That's a fair point. I actually prefer codecov myself. I'll go ahead and merge this for now.