Open SimenB opened 7 years ago
doesn't look like google cloud common is a regular dependency of this package. are you sure it isn't installed by some funky post install script? https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/package.json
If the package is a runtime dependency of a dependant package in the node_modules tree, then it should be embedded accordingly in the nar
archive.
Are you sure that the package has been installed properly and exists in node_modules/@google-cloud/storage
?
I'm getting a native module compilation issue while installing that package (due to grpc
installation).
I fix that issue using Python 2.7.
Looks like there's a bug here. That package should be resolved and embedded accordingly, but it does not.
As temporal workaround, I'd suggest creating explicitly adding @google-cloud/common
as root level dependency in your package.json
.
I can confirm that the above workaround solves the issue.
I will dig into details about why that dependency is not properly embedded, but my suspect is that this can be related to organization-based package naming issue.
Cool, thanks for the workaround, I'll test it Monday 😄
The workaround does work, thanks! Would of course prefer to avoid it, but it does work now, which is what matters 😄
Cool. Hopefully, I will have some time this weekend to fix the issue.
@h2non Any news here? 😄
@SimenB unfortunately, not yet. I have other things in the queue, but will try to come up with a fix in the upcoming weeks.
See https://github.com/finn-no/cdn-uploader
Doing
npm run create-executable && chmod +x cdn-uploader-linux-x64.nar && ./cdn-uploader-linux-x64.nar exec -a meep ugh
gives@google-cloud/common
is a dep of@google-cloud/storage
.