HTTP2 Push failures aren't logged

h2o / h2o

H2O - the optimized HTTP/1, HTTP/2, HTTP/3 server

https://h2o.examp1e.net

MIT License

10.85k stars 840 forks source link

HTTP2 Push failures aren't logged #1682

Open Alexander-- opened 6 years ago

Alexander-- commented 6 years ago

As noted in #1284, attempting to push a resource from different domain currently fails.

Unfortunately, the failure is completely silent — the cause of issue is impossible to deduce from access/error log files or syslog output. This makes debugging push issues a lot harder.

h2o should log all invalid/rejected Link headers, including the reason for rejection.

worenga commented 6 years ago

I strongly support this and I think it is a good idea to log when pushes are being dropped.

I had to debug this myself and for a user/developer it seems to be a guessing game to figure out why pushes are dropped. If i find time i'll work on a fix for this.