Closed kazuho closed 1 year ago
Looks good.
Isn't handling multiple platforms fun?
By the way, what happened to the proposal to replace "#ifdef _WINDOWS" by "_WIN32"?
Isn't handling multiple platforms fun?
It is always surprising how costly it is to support platforms that only support legacy standards; let the standard be ISO C or an IETF protocol :-)
@huitema Re _WIN32
, I believe @mattn pushed an empty commit to rerun the CI on AppVeyor. Would you mind taking a look?
aligned_alloc
is unavailable on Windows and we map that to_aligned_malloc
at lib/fusion.c line 63.Official documentation of _aligned_malloc states: Don't use free, which doesn't reclaim the aligned memory correctly and can lead to hard-to-diagnose bugs.