h2o / picotls

TLS 1.3 implementation in C (master supports RFC8446 as well as draft-26, -27, -28)
536 stars 140 forks source link

[openssl backend] remove unnecessary check #466

Closed kazuho closed 1 year ago

kazuho commented 1 year ago

It seems that since #310, openssl AEAD backend have been testing if supplied key is NULL and returning success if that is the case, while other backends have continued to assume key is non-NULL and crash if a NULL keys is supplied.

I believe this was an unintentional change is #310 and nobody is passing a NULL key (this call path can executed only once per object and passing a NULL key makes AEAD unusable), and therefore this PR removes that if.