search

h2o / picotls

TLS 1.3 implementation in C (master supports RFC8446 as well as draft-26, -27, -28)
527 stars 140 forks source link

support mbedtls as backend #495

Closed kazuho closed 8 months ago

kazuho commented 8 months ago

Subsumes #485.

huitema commented 8 months ago

@kazuho: thanks for picking up this PR. Is there a way I can see the differences from #485? That might help me improve the next PR...

It seems that we have an issue with the cmake discovery. Do you want me to try debug it?

kazuho commented 8 months ago

@huitema Thank you for reviews. This PR has been merged.

Only one question left: should we write some documentation on how to use MbedTLS? or, should we wait until we have ported the signature and verify functions?

I think we can add docs to https://github.com/h2o/picotls/wiki now that this PR has been merged. I can see the docs written in two ways. We can expand https://github.com/h2o/picotls/wiki/Using-picotls as it talks about two backends that we have already. Or, we can create a new document dedicated mbedtls backend. I'm fine either ways, but maybe the latter would be simpler and easier to understand?