search

h2o / picotls

TLS 1.3 implementation in C (master supports RFC8446 as well as draft-26, -27, -28)
535 stars 140 forks source link

picotls build seems to fail? #503

Closed Milind-Blaze closed 10 months ago

Milind-Blaze commented 10 months ago

Hi, I am setting up picotls on an Ubuntu VM (via UTM) on my M1 Mac. Running the following commands 

git clone https://github.com/h2o/picotls.git
git submodule init
cd picotls
git submodule init
git submodule update
cmake .
make
make check

seems to produce the following output

[100%] Built target test-minicrypto.t
make[3]: *** No rule to make target 'cli', needed by 'CMakeFiles/check'.  Stop.
make[2]: *** [CMakeFiles/Makefile2:110: CMakeFiles/check.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:117: CMakeFiles/check.dir/rule] Error 2
make: *** [Makefile:131: check] Error 2

I am unsure what to make of this error. Can someone please let me know how I can fix this? Thanks!

kazuho commented 10 months ago

This is because OpenSSL is missing as a dependency. make check depends on the cli command. cli command uses libcrypto, the crypto part of OpenSSL, as the backend.

As the platform is ubuntu, installing the libssl-dev package should fix the problem.

Milind-Blaze commented 10 months ago

Hi @kazuho , thank you for the clarification, that helps!

I also had to follow the instructions from here to get all the tests to pass. Mentioning for the sake of completeness.