Open barracuda156 opened 3 months ago
Submodule deps/picotest is outdated. Please run git submodule update --init --recursive
.
@kazuho Thank you, you are right, those errors are gone with picotest
updated to the current commit.
I can build picotls
now with gcc locally with no failures, however I see failures with clang on CI:
/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_picotls/picotls/work/picotls-9de892ccf7b1d3dc9467ef92ba9314c155928037/lib/mbedtls_sign.c:619:16: error: call to undeclared function 'mbedtls_pk_load_file'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if ((ret = mbedtls_pk_load_file(pem_fname, &buf, &n)) != 0) {
^
/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_picotls/picotls/work/picotls-9de892ccf7b1d3dc9467ef92ba9314c155928037/lib/mbedtls_sign.c:619:16: note: did you mean 'mbedtls_mpi_read_file'?
/opt/local/include/mbedtls/bignum.h:517:5: note: 'mbedtls_mpi_read_file' declared here
int mbedtls_mpi_read_file(mbedtls_mpi *X, int radix, FILE *fin);
^
1 error generated.
make[2]: *** [CMakeFiles/picotls-mbedtls.dir/lib/mbedtls_sign.c.o] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_picotls/picotls/work/build'
make[1]: *** [CMakeFiles/picotls-mbedtls.dir/all] Error 2
My fault. Developing this code, I used the API mbedtls_pk_load_file because it was a convenient way to load in memory the text content of a file. But this API was removed in the last versions of MbedTLS. I should have a replacement pretty soon.
@huitema Please ping me once ready, I will update the port in MacPorts then.
The fix is ready in PR #519. I am waiting for review by @kazuho to check it in main.
Actually, I had to close PR #519, and restart with PR #528. The good news is that this now a complete implementation, with support for loading private keys and verifying certificates. That PR is ready, waiting for reviews before check-in.
@huitema Thank you! I will update our port once the PR gets merged.
@h2o Building from 9de892ccf7b1d3dc9467ef92ba9314c155928037 I get the following failure on MacOS: