Closed samukweku closed 1 year ago
@oleksiyskononenko I do not understand the rules for void
when computing the mean. If you have some time, I'd love your feedback on it
@samukweku So what is your question on voids?
@samukweku I see your problem now. I guess our existing mean()
implementation is not consistent when it comes to groupby context. For void columns
SType::VOID
: https://github.com/h2oai/datatable/blob/main/src/core/expr/head_reduce_unary.cc#L223SType::FLOAT64
: https://github.com/h2oai/datatable/blob/main/src/core/expr/head_reduce_unary.cc#L245-L246On this PR we have already fixed that inconsistency and now only the failing tests have to be fixed. Go ahead and adjust the types in the reference frames to dt.float64
.
Is there anything else you're planning to do on this PR? Not sure why the build is failing.
@oleksiyskononenko Just ur review and merge is what's left
The build is read, so we first need to make it green before merging. Can you re-trigger the build to see if it was a temp glitch on AppVeyor?
Sure, will do
@samukweku once I merge https://github.com/h2oai/datatable/pull/3412, please remove your changes to test_median*
tests and merge main
onto your PR. test_median*
tests have typos and testing mean()
instead of median()
.
Nevermind, I've already made the required fixes. See if you have anything else to be done for this PR, otherwise, I guess it is all good to be merged.
Thanks @oleksiyskononenko all good from me. Ok to merge
mean()
reducer to useFExpr
;median()
to usefloat64
for void columns.WIP for #2562