Fix target column type detection in `LinearModel`

h2oai / datatable

A Python package for manipulating 2-dimensional tabular data structures

https://datatable.readthedocs.io

Mozilla Public License 2.0

1.81k stars 155 forks source link

Fix target column type detection in `LinearModel` #3467

Closed oleksiyskononenko closed 1 year ago

oleksiyskononenko commented 1 year ago

In this PR we

fix target column type detection in LinearModel;
remove disabled tests, that the model never supported (were inherited from Ftrl).

Closes #3466

st-pasha commented 1 year ago

why remove tests?

oleksiyskononenko commented 1 year ago

The tests removed were inherited from Ftrl that supports categorical features, the LinearModel doesn't, so they were disabled from the very beginning only adding meaningless log messages when doing make test. If at any point we need to re-use some code from these tests, it is available in tests/models/test-ftrl.py.