search

h2oai / db-benchmark

reproducible benchmark of database-like ops
https://h2oai.github.io/db-benchmark
Mozilla Public License 2.0
321 stars 85 forks source link

Update to Julia 1.6 release #193

Closed bkamins closed 3 years ago

bkamins commented 3 years ago

I will try to check if any other files require updating

bkamins commented 3 years ago

@jangorecki are the changes OK?

bkamins commented 3 years ago

I have also added an option to launch Julia using multiple threads (soon this will be used by DataFrames.jl).

bkamins commented 3 years ago

@jangorecki - could I somehow help you with this? (no rush of course, as I am aware you are putting tons of work into this project)

I also have a question. In the PR I have proposed to use all available logical cores on the machine. Do you have the same setting in other frameworks, or limit it to the number of physical cores? (to ensure we compare the same thing on different platforms). Thank you!

@nalimilan - could you please x-check my PR?

jangorecki commented 3 years ago

I am recently on another project, and currently on vacations. Anyway I will try to push this change sooner as it should be pretty simple. As for the number of cores you have to look scripts for configuration. DT uses all, other tools I don't remember, configuration was contributed by members of those communities or left default/all.

bkamins commented 3 years ago

Thank you for the response. Let us use the default then as proposed in this PR.