search

h2oai / deepwater

Deep Learning in H2O using Native GPU Backends
Apache License 2.0
282 stars 93 forks source link

fix javacpp git submodule bug #24

Closed DjangoPeng closed 7 years ago

DjangoPeng commented 7 years ago

If we git submodule in thirdparty directory, it would cause such error below:

You need to run this command from the toplevel of the working tree.

So, I updated the instructions of Javacpp presets, and run it in the top-level directory.

mdymczyk commented 7 years ago

I'll approve and merge this as there's indeed no reason for that cd but just FYI this isn't the case for 2.5 years now - git has dropped the top level requirement in git 1.8.4 (August 2013 commit 091a6eb).

DjangoPeng commented 7 years ago

@mdymczyk I checked my git version(1.8.3.1) and agree with you. BTW: the javaccp is really a typo bug.